Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[April 27, 2023 9AM PST] dbt Cloud GA for Starburst/Trino adapter support #3220

Merged
merged 25 commits into from
Apr 27, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Apr 19, 2023

What are you changing in this pull request and why?

To support the GA of the Starburst/Trino adapter in dbt Cloud, remove the public preview calllout and update prerequisites in the quickstart:

https://docs.getdbt.com/docs/quickstarts/dbt-cloud/starburst-galaxy

Checklist

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 14416f2
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/644a9abbb8aa040008e2c663
😎 Deploy Preview https://deploy-preview-3220--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. and removed Docs team Authored by the Docs team @dbt Labs labels Apr 19, 2023
@nghi-ly nghi-ly marked this pull request as ready for review April 19, 2023 21:27
@nghi-ly nghi-ly requested a review from a team as a code owner April 19, 2023 21:27
mirnawong1 and others added 2 commits April 20, 2023 11:44
release note to accompany apr 27th ga for starburst/trino ga. cc @Fleid
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Apr 20, 2023
runleonarun
runleonarun previously approved these changes Apr 26, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for GA on Thursday.

small changes to starburst trino, this should be merged thurs pst (apr
27th) alongside pr #3220 GA launch

per [slack
thread](https://dbt-labs.slack.com/archives/C02NCQ9483C/p1682422591945219?thread_ts=1681986411.262729&cid=C02NCQ9483C)
and confirmed by PM.

## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If linked to an open
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

## Checklist
- [ ] MERGE APR 27th
@mirnawong1 mirnawong1 requested a review from dataders as a code owner April 26, 2023 16:14
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Apr 26, 2023
release note to accompany apr 27th ga for starburst/trino ga. to merge
apr 27th

cc @Fleid

## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If linked to an open
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

## Checklist
- [ ] MERGE APR 27th
@mirnawong1
Copy link
Contributor

hey @runleonarun my two pr's are merged and you should now be able to see the full pr for this - thank yoU!

@runleonarun runleonarun changed the title dbt Cloud GA for Starburst/Trino adapter support [April 27, 2023 9AM PST] dbt Cloud GA for Starburst/Trino adapter support Apr 26, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to 🚢! Approving for tomorrow's GA

@runleonarun runleonarun merged commit db98b89 into current Apr 27, 2023
@runleonarun runleonarun deleted the ly-docs-starburst-ga branch April 27, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants