Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lauren's article on complex deduplication #1359

Merged
merged 15 commits into from
May 12, 2022
Merged

Add Lauren's article on complex deduplication #1359

merged 15 commits into from
May 12, 2022

Conversation

gwenwindflower
Copy link
Contributor

@gwenwindflower gwenwindflower commented Apr 20, 2022 •
edited
Loading

Description & motivation

Add's @lbenezra-FA article on removing partial duplicates

To-do before merge

  • Add Lauren to authors.yml
  • Fill in TODO in frontmatter with correct metadata

@netlify
Copy link

netlify bot commented Apr 20, 2022 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 390304c
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/627d384cf2bea10009c6a726
😎 Deploy Preview https://deploy-preview-1359--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gwenwindflower gwenwindflower self-assigned this Apr 20, 2022
@gwenwindflower gwenwindflower added the developer blog This content fits on the developer blog. label Apr 20, 2022
lbenezra-FA
lbenezra-FA approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@lbenezra-FA lbenezra-FA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks gooooood!!!

@gwenwindflower gwenwindflower force-pushed the gw/feature/lb-complex-deduplication-article branch from a048315 to b8e22e5 Compare May 2, 2022 19:04
@gwenwindflower gwenwindflower marked this pull request as ready for review May 2, 2022 19:24
@gwenwindflower gwenwindflower requested review from a team, annafil and runleonarun as code owners May 2, 2022 19:24
@gwenwindflower
Copy link
Contributor Author

@KiraFuruichi can you give me some extra eyes on this when you get a sec? i think i'm missing something done but this article isn't showing up in the preview for some reason...

@gwenwindflower
Copy link
Contributor Author

@KiraFuruichi can you give me some extra eyes on this when you get a sec? i think i'm missing something done but this article isn't showing up in the preview for some reason...

oops think i just saw it, needs a slug

@KiraFuruichi
Copy link
Contributor

@gwenwindflower do you see it showing up in the preview now? I still don't for some reason

@gwenwindflower
Copy link
Contributor Author

@KiraFuruichi nope i thought that was it but i don't either still!

simon's post worked earlier today, not sure what's happening with this one...

@KiraFuruichi
Copy link
Contributor

KiraFuruichi commented May 2, 2022 •
edited
Loading

wait @gwenwindflower I don't think the main blog page is a .md file hahah (like it's missing .md from it)

@gwenwindflower
Copy link
Contributor Author

ahh yep, there it is thanks @KiraFuruichi !!

@gwenwindflower @KiraFuruichi
Fix title casing
7c46d6a 
Co-authored-by: Kira Furuichi <[email protected]>
@KiraFuruichi KiraFuruichi self-requested a review May 2, 2022 21:56
@johnblust johnblust merged commit e21f67f into current May 12, 2022
@johnblust johnblust deleted the gw/feature/lb-complex-deduplication-article branch May 12, 2022 16:40
@gwenwindflower gwenwindflower mentioned this pull request May 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbenezra-FA lbenezra-FA lbenezra-FA approved these changes

@KiraFuruichi KiraFuruichi KiraFuruichi approved these changes

@annafil annafil Awaiting requested review from annafil

@runleonarun runleonarun Awaiting requested review from runleonarun

Assignees

@gwenwindflower gwenwindflower

Labels
developer blog This content fits on the developer blog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwenwindflower @KiraFuruichi @lbenezra-FA @johnblust