Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt v1 compat #453

Merged
merged 15 commits into from
Dec 2, 2021
Merged

dbt v1 compat #453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b42e6f9
dbt 0.7.4 release (#441)
joellabes Nov 11, 2021
77f537b
Merge branch 'main' into next/patch
joellabes Nov 26, 2021
8b38a56
Regression: Correctly handle missing relations in get_column_values (…
joellabes Dec 2, 2021
0859537
Add missing curlies
joellabes Dec 2, 2021
0df84c3
what person wrote this code :/ (it was me)
joellabes Dec 2, 2021
68b187f
wrap values in quotes
joellabes Dec 2, 2021
ef240c7
GOOD
joellabes Dec 2, 2021
614a8fc
bigquery compat (they don't like except)
joellabes Dec 2, 2021
fd8dc17
Backport android url changes from #426 (#452)
joellabes Dec 2, 2021
db8a047
Update CHANGELOG.md
joellabes Dec 2, 2021
f367880
Merge branch 'main' into next/minor
joellabes Dec 2, 2021
f6b4e4c
Change require-dbt-version, update dbt_project.yml for integration te…
joellabes Dec 2, 2021
a5a0b2f
Upgrade python version in CI, improve drop relation integration test
joellabes Dec 2, 2021
3cb69fb
Clarify version pinning
joellabes Dec 2, 2021
77411a9
Drop support for release candidates of 1.0.0
joellabes Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Backport android url changes from #426 (#452)
  • Loading branch information
@joellabes
joellabes authored Dec 2, 2021
commit fd8dc17ba9df576fcaef9c16bb0899e528018ba3
5 changes: 4 additions & 1 deletion integration_tests/data/web/data_url_host.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
original_url,parsed_url
www.google.co.uk?utm_source=google&utm_medium=cpc&utm_campaign=spring-summer,www.google.co.uk
http://witanddelight.com/2018/01/tips-tricks-how-run-half-marathon-first-time/,witanddelight.com
https://www.nytimes.com/2018/01/01/blog,www.nytimes.com
https://www.nytimes.com/2018/01/01/blog,www.nytimes.com
android-app://m.facebook.com/,m.facebook.com
docs.nytimes.com/2021/01/01/index.js?utm_source=google,docs.nytimes.com
https://m.facebook.com/,m.facebook.com
11 changes: 6 additions & 5 deletions macros/web/get_url_host.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,24 @@

{% macro default__get_url_host(field) -%}

{%- set parsed =
{%- set parsed =
dbt_utils.split_part(
dbt_utils.split_part(
dbt_utils.replace(
dbt_utils.replace(field, "'http://'", "''"
dbt_utils.replace(
dbt_utils.replace(field, "'android-app://'", "''"
), "'http://'", "''"
), "'https://'", "''"
), "'/'", 1
), "'?'", 1
)

-%}


{{ dbt_utils.safe_cast(
parsed,
dbt_utils.type_string()
)}}


{%- endmacro %}