Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker image to the repo #876

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add docker image to the repo #876

merged 3 commits into from
Aug 31, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Aug 17, 2023

I think it makes sense to have the Dockerfile
in the repository itself.

Resolves #739

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@Fokko Fokko requested a review from a team as a code owner August 17, 2023 12:53
@Fokko Fokko requested a review from VersusFacit August 17, 2023 12:53
@cla-bot cla-bot bot added the cla:yes label Aug 17, 2023
@Fokko Fokko force-pushed the fd-add-docker-image branch 3 times, most recently from cd3ebc0 to ba014f7 Compare August 17, 2023 12:57
@Fokko
Add docker image to the repo
ed43b77 
I think it makes sense to have the Dockerfile
in the repository itself.

Resolves dbt-labs#739
@Fokko Fokko force-pushed the fd-add-docker-image branch from ba014f7 to ed43b77 Compare August 17, 2023 13:22
@Fokko
Copy link
Contributor Author

Fokko commented Aug 17, 2023

cc @JCZuurmond

@Fokko
Copy link
Contributor Author

Fokko commented Aug 17, 2023

cc @emmyoop Sorry for the long wait!

@colin-rogers-dbt colin-rogers-dbt merged commit efa1b18 into dbt-labs:main Aug 31, 2023
@Fokko Fokko deleted the fd-add-docker-image branch September 29, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-484] [SPIKE] Can we use an alternative to godatadriven/pyspark:3.1
3 participants
@Fokko @colin-rogers-dbt @dataders