Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent secret key and session token from being logged #638

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: prevent secret key and session token from being logged #638

merged 1 commit into from
May 3, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented May 2, 2024 •
edited
Loading

Description

Currently any fields returned by _connection_keys are considered safe to log while debugging. This could lead to these credentials being logged unintentionally.

Models used to test - Optional

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review May 2, 2024 23:47
@colin-rogers-dbt colin-rogers-dbt changed the title prevent secret key and session token from being logged Prevent secret key and session token from being logged May 2, 2024
@colin-rogers-dbt colin-rogers-dbt changed the title Prevent secret key and session token from being logged feat: prevent secret key and session token from being logged May 2, 2024
@nicor88 nicor88 added the enable-functional-tests Label to trigger functional testing label May 3, 2024
@nicor88 nicor88 merged commit cefddc4 into dbt-labs:main May 3, 2024
12 checks passed
@nicor88 nicor88 changed the title feat: prevent secret key and session token from being logged fix: prevent secret key and session token from being logged May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicor88 nicor88 nicor88 approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@Jrmyy Jrmyy Awaiting requested review from Jrmyy

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@svdimchenko svdimchenko Awaiting requested review from svdimchenko

Assignees
No one assigned
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @nicor88