fix: get_columns_in_relation for LAMBDA catalogs #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a catalog of type LAMBDA (e.g. federated query) you will get errors like the following:
It's because we set the catalog ID to
None
when we actually need to not-pass it.You would probably get the same problem using HIVE type but I haven't tested that.
Models used to test - Optional
Trying to show some kind of reprex here, the full config is a bit much for a PR description. Let me know if you want to see more.
Create some Lambda function that host the Athena federated query app:
Create the Athena catalog:
Create the source:
Create a model:
Checklist
Dubious if this is worth functional+unit test or not, it's quite a lot of setup for a very small change and obviously not a lot of people are using dbt-athena + athena federated query otherwise they would have bumped into this.