fix: allow switch from hive to iceberg table #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicor88
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix and
svdimchenko
as code owners
Jrmyy
previously approved these changes
Apr 17, 2024
nicor88
commented
Apr 17, 2024
dbt/include/athena/macros/materializations/models/table/table.sql
Outdated
Show resolved
Hide resolved
Jrmyy
approved these changes
Apr 18, 2024
|
hey @nicor88 great job done! sorry for some late response from me here. |
|
@svdimchenko I believe that in case of incremental materialization we don't have 2 renames in case of iceberg, therefore I aspect that switching from hive to iceberg should work. But must be confirmed. Edit: in case of incremental load the user must issue a full refresh, that's the only way. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #478
Also add functional tests to be sure that we can switch smoothly from hive to iceberg, and from iceberg to hive.
This can be really helpfull, to allow users to change table type easily without a full-refresh.
For the functional tests I did a sort of hack, where I pass the table_type via a
table_typevar, that then it's used in the config like this:table_type=var("table_type"),works fine.Models used to test - Optional
Provided functional tests to cover the implementation
Checklist