HANA connection dialog: convert GENERIC + host=<host>:443 to CLOUD (#35045) #35046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contribution! |
serge-rider
requested changes
Aug 11, 2024
...rg.jkiss.dbeaver.ext.hana.ui/src/org/jkiss/dbeaver/ext/hana/ui/views/HANAConnectionPage.java
Outdated
Show resolved
Hide resolved
| @@ -182,7 +182,7 @@ public void loadSettings() { | |||
| super.loadSettings(); | |||
| DBPConnectionConfiguration connectionInfo = site.getActiveDataSource().getConnectionConfiguration(); | |||
| edition = HANAEdition.fromName(connectionInfo.getProviderProperty(PROV_PROP_EDITION)); | |||
| portValue = CommonUtils.toString(connectionInfo.getHostPort(), site.getDriver().getDefaultPort()); | |||
| portValue = CommonUtils.toString(connectionInfo.getHostPort()/*, site.getDriver().getDefaultPort()*/); | |||
There was a problem hiding this comment.
We don't need default port anymore?
There was a problem hiding this comment.
All editions except GENERIC have there own rule to calculate the port from other fields or have a fixed port.
GENERIC is not really an own edition, but a fallback that allows pasting already know host+port. The preset port was wrong in most cases as an on-premise HANA has an instance number in the range from 0 to 99 and the actual port depends on that number.
|
We passed your PR to our QA team for testing |
|
verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.