#34887 [TRINO] Enable SQL based row limits for trino #34888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E1izabeth
approved these changes
Jul 18, 2024
|
Thank you for contribution |
HocKu7
approved these changes
Jul 19, 2024
* When trino is configured with fault tolerant execution, queries are run to completion before results are returned * This means previewing a table in dbeaver ends up scanning the whole table and taking up potentially a huge amount of resources * Trino supports SQL limit statement, so enable SQL based row limiting in the plugin and make it the default
schaffino
force-pushed
the
trino/enable-sql-base-row-limit
branch
from
395e1c6 to
f4082b1
Compare
|
We passed your PR to our QA team for testing |
|
@E1izabeth Any update on this PR? |
|
This PR is awaiting in a queue for testing. |
|
verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trino is configured with fault tolerant execution, queries are run to completion before results are returned. This means previewing a table in dbeaver ends up scanning the whole table and taking a lot of time, and potentially a huge amount of resources if its a very large table. Trino supports SQL limit statement, so enable SQL based row limiting in the plugin and make it the default for connections.
Fixes #34887