Bugfix for php 5.3 #437
Bugfix for php 5.3 #437
Conversation
| @@ -212,4 +212,32 @@ public function testRequest() | |||
|
|
|||
| $this->assertSame('response!', $service->request('/my/awesome/path')); | |||
| } | |||
|
|
|||
| /** | |||
| * Test fails only in php5.3. | |||
There was a problem hiding this comment.
If it fails with PHP 5.3 why isn't the build failing?
There was a problem hiding this comment.
The pull request also contains the fix, and the CI only ran against the
most recent commit. The test will just guard against any future regressions.
On 15 Oct 2015 23:44, "Elliot Chance" [email protected] wrote:
In tests/Unit/OAuth1/Service/AbstractServiceTest.php
#437 (comment):@@ -212,4 +212,32 @@ public function testRequest()
$this->assertSame('response!', $service->request('/my/awesome/path')); }
- /**
\* Test fails only in php5.3.If it fails with PHP 5.3 why isn't the build failing?
—
Reply to this email directly or view it on GitHub
https://github.com/Lusitanian/PHPoAuthLib/pull/437/files#r42190656.
|
Hi! Any further thoughts on merging this PR? |
| $client->expects($this->once())->method('retrieveResponse')->will($this->returnValue('response!')); | ||
|
|
||
| $token = $this->getMock('\\OAuth\\OAuth1\\Token\\TokenInterface'); | ||
| //$token->expects($this->once())->method('getRequestTokenSecret')->will($this->returnValue('baz')); |
There was a problem hiding this comment.
Remove this line please
|
Hello, I've updated the comment and rebased on top of your new master. |
|
The original line that was commented out is still there. |
|
Ah, I misinterpreted which line you meant. That's gone. |
String index checking in php 5.3 permits string to integer casting, e.g.
This fix ensures the
$bodyParamsare anarraybefore trying to extract theoauth_session_handle