Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modernized tox environments/linting #127

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Add modernized tox environments/linting #127

merged 4 commits into from
Jan 3, 2024

Conversation

athornton
Copy link
Collaborator

Also...this ran the formatter, so it's a huge change.

@athornton
Copy link
Collaborator Author

@rufuspollock This is a very boring but very large changeset. Most of it is formatting (a lot of trailing whitespace deleted, some stuff that black did).

I've got the scaffolding in place to do Ruff (which Rubin is moving to in order to supplement Black), but it's very opinionated and will take a while to incorporate...Likewise there's the framework to generate changelogs from commit messages and to parse versions from git (which will let us eventually tag a release and push a build).

While our settings for black are basically "79 columns and Python 3.11, please", there's a whole lot configured for Ruff (it's in pyproject.toml) that's representative of the way my group in Rubin works, but might or might not be what you want for the Giftless project. Likewise with the mypy settings there as well, but those are (I think) more likely to just be unused here than something you actively don't want.

@rufuspollock
Copy link
Member

@athornton ok let's get this merged 😄

@rufuspollock rufuspollock merged commit bf397c7 into datopian:main Jan 3, 2024
@athornton
Copy link
Collaborator Author

Cool....I'm working on a queue of things now that really tighten up the type hinting, and get rid of the separate ini files for the most part (moving configuration under pyproject.toml).

@athornton athornton deleted the tickets/DM-42331 branch January 4, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants