Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): disable access management ui when no roles are linked to entity #9610

Merged
merged 8 commits into from
Mar 22, 2024
Merged

feat(UI): disable access management ui when no roles are linked to entity #9610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22e168b
feat(UI): disable access management ui when no roles are linked to en…
hrichert Jan 11, 2024
c08aa92
Merge branch 'master' into feature/disable-access-mgmt-tab-when-no-roles
githendrik Jan 18, 2024
f7e3915
Merge branch 'datahub-project:master' into feature/disable-access-mgm…
githendrik Jan 24, 2024
72ef2d6
feat(UI): disable access management ui when access aspect is set but …
hrichert Jan 24, 2024
5304459
Merge branch 'master' into feature/disable-access-mgmt-tab-when-no-roles
githendrik Feb 13, 2024
0267ebd
Merge branch 'master' into feature/disable-access-mgmt-tab-when-no-roles
githendrik Feb 20, 2024
09c827f
Merge branch 'master' into feature/disable-access-mgmt-tab-when-no-roles
githendrik Mar 18, 2024
ae504de
move 'visible' logic for Access Management to correct position
hrichert Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export class DatasetEntity implements Entity<Dataset> {
component: AccessManagement,
display: {
visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
enabled: (_, _2) => true,
enabled: (_, dataset: GetDatasetQuery) => !!dataset?.dataset?.access,
githendrik marked this conversation as resolved.
Show resolved Hide resolved
},
},
]}
Expand Down
7 changes: 7 additions & 0 deletions datahub-web-react/src/graphql/dataset.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ fragment nonSiblingDatasetFields on Dataset {
assertions(start: 0, count: 1) {
total
}
access {
roles {
role {
urn
}
}
}
operations(limit: 1) {
timestampMillis
lastUpdatedTimestamp
Expand Down
Loading