Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable gradle caching #9525

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 27, 2023

  1. Enables gradle task caching. This seems to be possible because of the pegasus and gradle version upgrades ( https://github.com/linkedin/rest.li/commits/master/gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java and linkedin/rest.li@7cfe8bf), even though it wasn't previously possible (4a77576)
  2. Use https://github.com/gradle/gradle-build-action in github actions to cache gradle dependencies. Not sure how much this will help, but it's worth a shot. We might need to audit our task dependencies and things to make sure the cache doesn't cause problems when working across machines.

For debugging the cache, we also now get nice reports as part of the PR run:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Dec 27, 2023
@hsheth2 hsheth2 marked this pull request as ready for review December 27, 2023 22:42
@hsheth2 hsheth2 requested review from david-leifker, noggi and anshbansal and removed request for noggi December 28, 2023 00:13
@hsheth2 hsheth2 merged commit 9f79f44 into datahub-project:master Dec 28, 2023
@hsheth2 hsheth2 deleted the gradle-enable-cache branch December 28, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants