Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: increase gradle retries #9091

Merged
merged 1 commit into from
Nov 1, 2023
Merged

build: increase gradle retries #9091

merged 1 commit into from
Nov 1, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 24, 2023

Honestly not sure what the right options are here, so just trying some things out.

See a lot of issues in CI https://github.com/datahub-project/datahub/actions/runs/6631594104/job/18015463615?pr=9061

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
build: increase gradle retries
c70ab55 
Honestly not sure what the right options are here, so just trying some
things out.
@hsheth2 hsheth2 requested a review from RyanHolstien October 24, 2023 19:58
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
asikowitz
asikowitz approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar enough with gradle to confirm these changes but want to unblock here

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Nov 1, 2023

The smoke test issues were fixed in a separate PR

@hsheth2 hsheth2 merged commit d231497 into datahub-project:master Nov 1, 2023
36 of 37 checks passed
@hsheth2 hsheth2 deleted the gradle-retries branch November 1, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @asikowitz @maggiehays