Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): Remove table name restrictions (allow $ and @) #9030

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(ingest/bigquery): Remove table name restrictions (allow $ and @) #9030

merged 1 commit into from
Oct 17, 2023

Conversation

asikowitz
Copy link
Collaborator

https://cloud.google.com/bigquery/docs/tables#table_naming makes no mention of $ or @ being forbidden. We don't know why this was there in the first place, so we're removing it

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested review from treff7es and hsheth2 October 17, 2023 14:58
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 17, 2023
@asikowitz
Copy link
Collaborator Author

Merging through what look like flakes

@asikowitz asikowitz merged commit da6cc54 into datahub-project:master Oct 17, 2023
51 of 54 checks passed
@asikowitz asikowitz deleted the remove-bigquery-table-name-restrictions branch October 17, 2023 20:18
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@treff7es treff7es Awaiting requested review from treff7es

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @gabe-lyons @maggiehays