feat(docs-website): add vercel preview environment #7644
Conversation
github-actions
bot
added
the
devops
hsheth2
changed the title
| @@ -31,3 +31,4 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
| .vscode | |||
| .vercel | |||
There was a problem hiding this comment.
Do we need both this and above?
| sudo_cmd="" | ||
| if command -v sudo; then | ||
| sudo_cmd="sudo" | ||
| fi |
There was a problem hiding this comment.
Not sure if we care, but this will print the result of command -v sudo to stdout. Can either pipe into /dev/null or check [ -x "$(command -v sudo)" ] as per https://stackoverflow.com/questions/592620/how-can-i-check-if-a-program-exists-from-a-bash-script
There was a problem hiding this comment.
Ah I didn't realize that
In this case I don't think we care because it's just the path to sudo and that script is only run in CI
| Sinks: [ | ||
| { | ||
| type: "autogenerated", | ||
| dirName: "metadata-ingestion/sink_docs", |
There was a problem hiding this comment.
How come these are in a different place from the source docs?
dirName: "docs/generated/ingestion/sources"
There was a problem hiding this comment.
The source docs are generated by another build script, whereas these are raw md files
| @@ -1,34 +1,3 @@ | |||
| const fs = require("fs"); | |||
|
|
|||
| function list_ids_in_directory(directory, hardcoded_labels) { | |||
| "silent": true, | ||
| "autoJobCancelation": true | ||
| }, | ||
| "installCommand": "amazon-linux-extras install python3.8 && py3=\"$(which python3)\" && rm \"$py3\" && ln \"$(which python3.8)\" \"$py3\" && ./metadata-ingestion/scripts/install_deps.sh && yum install -y gcc python38-devel", |
There was a problem hiding this comment.
How come we're using python3.8 here? And what is running this command?
There was a problem hiding this comment.
this command is being run by vercel, which is a third-party tool
Checklist