Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/s3): support path_specs of different S3 buckets in the same recipe #7514

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat(ingest/s3): support path_specs of different S3 buckets in the same recipe #7514

merged 1 commit into from
Mar 15, 2023

Conversation

harsha-mandadi-4026
Copy link
Contributor

@harsha-mandadi-4026 harsha-mandadi-4026 commented Mar 7, 2023 •
edited
Loading

Description

This PR:

  • Updates the code to support path specs of different S3 buckets in a recipe
  • Cleans up extra new lines etc in some files.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@harsha-mandadi-4026 harsha-mandadi-4026 marked this pull request as ready for review March 7, 2023 19:09
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 7, 2023
@harsha-mandadi-4026 harsha-mandadi-4026 changed the title feat(ingestion/s3): support path_specs of different S3 buckets in the same recipe feat(ingest/s3): support path_specs of different S3 buckets in the same recipe Mar 7, 2023
@harsha-mandadi-4026 harsha-mandadi-4026 changed the title feat(ingest/s3): support path_specs of different S3 buckets in the same recipe feat(ingest/s3): support path_specs of different S3 buckets in the a recipe Mar 10, 2023
@shirshanka shirshanka requested a review from mayurinehate March 12, 2023 18:17
@harsha-mandadi-4026
Copy link
Contributor Author

harsha-mandadi-4026 commented Mar 12, 2023 •
edited
Loading

Wondering if the failures in the metadata-ingestion 3.7 and 3.10 steps are because of the changes made here

@harsha-mandadi-4026 harsha-mandadi-4026 changed the title feat(ingest/s3): support path_specs of different S3 buckets in the a recipe feat(ingest/s3): support path_specs of different S3 buckets in a recipe Mar 12, 2023
@harsha-mandadi-4026 harsha-mandadi-4026 changed the title feat(ingest/s3): support path_specs of different S3 buckets in a recipe feat(ingest/s3): support path_specs of different S3 buckets in the same recipe Mar 12, 2023
mayurinehate
mayurinehate approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Apart from mocked integration tests, have you tested this with actual s3 buckets - using different s3 buckets in same recipe ?

@harsha-mandadi-4026
Copy link
Contributor Author

harsha-mandadi-4026 commented Mar 14, 2023 •
edited
Loading

LGTM.

Apart from mocked integration tests, have you tested this with actual s3 buckets - using different s3 buckets in same recipe ?

I did try this with the existing behaviour and it didn't support multiple S3 buckets in the same recipe but after removing the check for it, I think it should work just fine.

Could you re-approve this PR, please? This is out of date with master

@hsheth2 hsheth2 merged commit bf36c93 into datahub-project:master Mar 15, 2023
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 15, 2023
@harsha-mandadi-4026 @shirshanka
feat(ingest/s3): support path_specs of different S3 buckets in the sa…
abd92aa 
…me recipe (datahub-project#7514)
yoonhyejin pushed a commit to yoonhyejin/datahub-project-forked that referenced this pull request Mar 15, 2023
@harsha-mandadi-4026
feat(ingest/s3): support path_specs of different S3 buckets in the sa…
27f9c69 
…me recipe (datahub-project#7514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsha-mandadi-4026 @hsheth2 @mayurinehate