-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema and generated java to data model, refactor Gobblin audit p… #732
Conversation
2502f0d
to
a9311ce
Compare
import org.apache.commons.lang3.StringUtils; | ||
import wherehows.dao.table.DatasetClassificationDao; | ||
import wherehows.dao.table.DictDatasetDao; | ||
import wherehows.models.table.DatasetClassification; | ||
import wherehows.models.table.DictDataset; | ||
import wherehows.utils.StringUtil; | ||
|
||
import static wherehows.common.utils.StringUtil.toStringMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer non static import
wherehows-data-model/build.gradle
Outdated
println gradle.appBuildEnvironment | ||
|
||
if ("OpenSource" == gradle.appBuildEnvironment) { | ||
println "apply gradle.plugin.avro" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
settings.gradle
Outdated
@@ -17,3 +17,4 @@ modules.each { module -> | |||
include "${module}" | |||
} | |||
|
|||
gradle.ext.appBuildEnvironment = "OpenSource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"opensource"
…rocessor
The records will be converted to the java class generated by corresponding avro schema, simplify the following data processing.
Tested locally.