Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema and generated java to data model, refactor Gobblin audit p… #732

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

alyiwang
Copy link
Contributor

@alyiwang alyiwang commented Sep 8, 2017

…rocessor

The records will be converted to the java class generated by corresponding avro schema, simplify the following data processing.

Tested locally.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 0.536% when pulling b48ef76 on alyiwang:kafka into d1e53c7 on linkedin:master.

@alyiwang alyiwang force-pushed the kafka branch 2 times, most recently from 2502f0d to a9311ce Compare September 11, 2017 20:21
import org.apache.commons.lang3.StringUtils;
import wherehows.dao.table.DatasetClassificationDao;
import wherehows.dao.table.DictDatasetDao;
import wherehows.models.table.DatasetClassification;
import wherehows.models.table.DictDataset;
import wherehows.utils.StringUtil;

import static wherehows.common.utils.StringUtil.toStringMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer non static import

println gradle.appBuildEnvironment

if ("OpenSource" == gradle.appBuildEnvironment) {
println "apply gradle.plugin.avro"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 0.534% when pulling a9311ce on alyiwang:kafka into 6e87040 on linkedin:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 0.534% when pulling a9311ce on alyiwang:kafka into 6e87040 on linkedin:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 0.534% when pulling e11a7de on alyiwang:kafka into 6e87040 on linkedin:master.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

settings.gradle Outdated
@@ -17,3 +17,4 @@ modules.each { module ->
include "${module}"
}

gradle.ext.appBuildEnvironment = "OpenSource"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"opensource"

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 0.534% when pulling 1b553b4 on alyiwang:kafka into 6e87040 on linkedin:master.

@alyiwang alyiwang merged commit d2a3fe5 into datahub-project:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants