feat(api): Timeline API supports Glossary Terms now #7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
anshbansal
added
the
community-contribution
RyanHolstien
requested changes
Feb 6, 2023
metadata-io/src/main/java/com/linkedin/metadata/timeline/TimelineServiceImpl.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/timeline/TimelineServiceImpl.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for feedback. |
RyanHolstien
reviewed
Feb 7, 2023
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
aditya-radhakrishnan
added
the
platform
RyanHolstien
approved these changes
Feb 7, 2023
jjoyce0510
reviewed
Feb 8, 2023
| import static com.linkedin.metadata.timeline.eventgenerator.EditableDatasetPropertiesChangeEventGenerator.*; | ||
|
|
||
|
|
||
| public class GlossaryTermInfoChangeEventGenerator extends EntityChangeEventGenerator<GlossaryTermInfo> { |
Collaborator
There was a problem hiding this comment.
Would recommend adding a unit test for this class!
Collaborator
There was a problem hiding this comment.
Will add a backlog item to add a test for this and Datasets as well. Looks like we don't have one on it either. I think we can get this in though unless you want to block on that.
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…7229) Co-authored-by: RyanHolstien <[email protected]> Co-authored-by: Shirshanka Das <[email protected]>
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
…7229) Co-authored-by: RyanHolstien <[email protected]> Co-authored-by: Shirshanka Das <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline API is expanded with Glossary Terms support.
Checklist