Skip to content

feat(ingest): mark database_alias and env as deprecated #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anshbansal merged 3 commits into from
Jan 9, 2023
Merged

feat(ingest): mark database_alias and env as deprecated #6901

anshbansal merged 3 commits into from
Jan 9, 2023

Conversation

@hsheth2
Copy link
Contributor

@hsheth2 hsheth2 commented Dec 30, 2022

  • Adds pydantic_field_deprecated helper
  • Adds a custom ConfigurationWarning type
  • Removes duplicate config options from a few places

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(ingest): mark database_alias and env as deprecated
727662e 
- Adds pydantic_field_deprecated helper
- Adds a custom ConfigurationWarning type
- Removes duplicate config options from a few places
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 30, 2022
@anshbansal
Copy link
Collaborator

anshbansal commented Dec 30, 2022

We need to mark deprecated things in https://github.com/datahub-project/datahub/blob/master/docs/how/updating-datahub.md

aditya-radhakrishnan
aditya-radhakrishnan approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anshbansal anshbansal merged commit 432feaa into datahub-project:master Jan 9, 2023
@hsheth2 hsheth2 deleted the env-deprecation branch January 11, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ingestion PR or Issue related to the ingestion of metadata

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsheth2 @anshbansal @aditya-radhakrishnan