Skip to content

feat(gms): Pluggable Authentication & Authorization Framework #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjoyce0510 merged 113 commits into from
Dec 6, 2022
Merged

feat(gms): Pluggable Authentication & Authorization Framework #6634

jjoyce0510 merged 113 commits into from
Dec 6, 2022

Conversation

@siddiquebagwan
Copy link
Contributor

@siddiquebagwan siddiquebagwan commented Dec 5, 2022

No description provided.

@siddiquebagwan-gslab
rename package of auth-api to com.datahub.plugins.auth
b98ed89
@siddiquebagwan-gslab
type public
b10b578
@siddiquebagwan-gslab
rename com.datahub.auth
3eec5b6
@siddiquebagwan-gslab
move to metadata-auth
8a7d25f
@siddiquebagwan-gslab
copied original metadata-auth
ee98360
@siddiquebagwan-gslab
updated to point to metadata-auth
a177b99
@siddiquebagwan-gslab
metadata-auth:auth-api
44bf372
@siddiquebagwan-gslab
WIP
662cfae
@siddiquebagwan-gslab
Added plugin code
c82147d
@siddiquebagwan-gslab
plugin integrated
12e9699
@siddiquebagwan-gslab
config
472a1cc
@siddiquebagwan-gslab
integrated plugin into GMS
4719cc8
@siddiquebagwan-gslab
authenticator chain is working
fbe2ee2
@siddiquebagwan-gslab
allow log4j for apache-ranger-plugin
0683b55
@siddiquebagwan-gslab
Merge branch 'master' into master+acr-3593-pluggable-auth-framework
e526c3b
@siddiquebagwan-gslab
remove apache-ranger config from start.sh
6dfc3e2
@siddiquebagwan-gslab
Empty enumeration from findResources
a918b41
@siddiquebagwan-gslab
Working GMS with Pluggable Auth Framework
7d07e8c
@siddiquebagwan-gslab
doc
ea90984
@siddiquebagwan-gslab
fix javadoc error
34ca6c2
@siddiquebagwan-gslab
rename pluginDirectory to pluginHome
c202df3
@siddiquebagwan-gslab
doc update
7feb007
@siddiquebagwan-gslab
fix merge conflict
2884152
@siddiquebagwan-gslab
doc updated
c0d8ea2
@siddiquebagwan-gslab
doc fix
4cfcd82
@siddiquebagwan-gslab
resolve merge conflict
f3d3000
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
a2d6d76 
…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework
@siddiquebagwan-gslab
review comments
96403c2
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
0169754 
…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework
@siddiquebagwan-gslab
Remove unrelated classes from plugins folder
f251e1f
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022 •
edited
Loading

Unit Test Results (build & test)

633 tests  +11   629 ✔️ +11   15m 46s ⏱️ +7s
162 suites +  4       4 💤 ±  0 
162 files   +  4       0 ❌ ±  0 

Results for commit 6665d53. ± Comparison against base commit 43c566e.

This pull request removes 4 and adds 15 tests. Note that renamed tests count towards both. 
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationAllow
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationDeny
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig

com.datahub.plugins.auth.TestConfig ‑ testConfig
com.datahub.plugins.auth.TestConfigProvider ‑ testConfigurationLoading
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotHaveDuplicate
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testMapShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testWhiteSpacesValidation
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthenticatorPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthorizerPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testDuplicatePluginName
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testIncorrectImplementation
…

♻️ This comment has been updated with latest results.

pedro93 and others added 11 commits December 5, 2022 09:58
@pedro93
Merge branch 'master' into master+acr-3593-pluggable-auth-framework
aaeb77b
@siddiquebagwan-gslab
Move apache-ranger related code to new repo acryldata/datahub-ranger-…
4355e58 
…auth-plugin
@siddiquebagwan-gslab
resolve merge conflict
760745b
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
42e9d75 
…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
c5d548a 
…:mohdsiddique/datahub into master+acr-3593-pluggable-auth-framework
@siddiquebagwan-gslab
Fix issue in auth-api publish
914fbb8
@siddiquebagwan-gslab
publish shadow jar for datahub-auth-api
eebd3c8
@siddiquebagwan-gslab
Merge branch 'master' into master+acr-3593-pluggable-auth-framework
1b55634
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
4680cb4 
…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework
@siddiquebagwan-gslab
make normal jar
eeaab51
@siddiquebagwan-gslab
Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…
6665d53 
…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework
jjoyce0510
jjoyce0510 reviewed Dec 6, 2022
View reviewed changes
docs/how/updating-datahub.md
## Next

### Breaking Changes
- #6243 apache-ranger authorizer is no longer the core part of DataHub GMS, and it is shifted as plugin. Please refer updated documentation [Configuring Authorization with Apache Ranger](./configuring-authorization-with-apache-ranger.md#configuring-your-datahub-deployment) for configuring `apache-ranger-plugin` in DataHub GMS.
Copy link
Collaborator

@jjoyce0510 jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jjoyce0510
jjoyce0510 reviewed Dec 6, 2022
View reviewed changes
metadata-service/factories/build.gradle
compile externalDependency.springKafka
compile externalDependency.springWeb
compile project(':metadata-service:auth-ranger-impl')

Copy link
Collaborator

@jjoyce0510 jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

jjoyce0510
jjoyce0510 reviewed Dec 6, 2022
View reviewed changes
metadata-service/factories/src/main/resources/application.yml
pluginSecurityMode: ${PLUGIN_SECURITY_MODE:RESTRICTED} # Possible value RESTRICTED or LENIENT, default to RESTRICTED
entityRegistry:
path: ${ENTITY_REGISTRY_PLUGIN_PATH:/etc/datahub/plugins/models}
path: ${ENTITY_REGISTRY_PLUGIN_PATH:/etc/datahub/plugins/models}
Copy link
Collaborator

@jjoyce0510 jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong to me

jjoyce0510
jjoyce0510 reviewed Dec 6, 2022
View reviewed changes
metadata-service/plugin/src/main/java/com/datahub/plugins/common/SecurityMode.java
/**
* In this mode plugins has limited access.
*
* Plugins are allowed to connect on below ports only
Copy link
Collaborator

@jjoyce0510 jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice doc!

jjoyce0510
jjoyce0510 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@jjoyce0510 jjoyce0510 merged commit f2a83f3 into datahub-project:master Dec 6, 2022
purnimagarg1 added a commit that referenced this pull request Sep 19, 2025
@purnimagarg1 @chriscollins3456
fix(summary-tab): show correct feedback when trying to add duplicate …
098b1f4 
…link (#6634)

Co-authored-by: Chris Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

No one assigned

Labels

devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddiquebagwan @jjoyce0510 @siddiquebagwan-gslab @pedro93