Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(patch): initial support of json patch style semantics in MCPs #5901

Merged
merged 31 commits into from
Sep 23, 2022
Merged

feat(patch): initial support of json patch style semantics in MCPs #5901

merged 31 commits into from
Sep 23, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 11, 2022
@github-actions
Copy link

github-actions bot commented Sep 11, 2022 •
edited
Loading

Unit Test Results (build & test)

568 tests  +6   564 ✔️ +2   13m 2s ⏱️ +7s
140 suites +1       4 💤 +4 
140 files   +1       0 ❌ ±0 

Results for commit db59bfa. ± Comparison against base commit 3a6d1d2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 11, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 16s ⏱️ -9s
   717 tests ±0     714 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 436 runs  ±0  1 430 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit db59bfa. ± Comparison against base commit 3a6d1d2.

♻️ This comment has been updated with latest results.

shirshanka and others added 23 commits September 11, 2022 11:44
@shirshanka
Merge remote-tracking branch 'upstream/master' into feat/patch
9d4d662
@shirshanka
small refactor, add smoke-test
7ee2d65
@shirshanka
fix lint
8c45da4
@shirshanka
more tests
5b0072b
@shirshanka
Remove unnecessary file
cb7dc66
@shirshanka
ignore misisng callback
b71f860
@shirshanka
fix ownership patch construction
e5eb98d
@RyanHolstien
fix ownershippatchbuilder
67f2134
@anshbansal @shirshanka
fix(ci): fix globs for auto-labeling PRs (datahub-project#5903)
5c36371
@mayurinehate @shirshanka
feat(ingest): snowflake-beta - minor changes, tests (datahub-project#…
b02102a 
…5910)
@hieunt-itfoss @shirshanka
feat(ingestion): schema inference for jsonlines in S3 (datahub-projec…
9406746 
…t#5725)

Co-authored-by: Nguyen Tri Hieu <[email protected]>
@jjoyce0510 @shirshanka
refactor(gms): Refactoring util + entity client class locations (data…
2da85e9 
…hub-project#5902)
@shirshanka
Merge branch 'master' into feat/patch
a26183a
@RyanHolstien
fix test
5914173
@shirshanka
Merge branch 'master' into feat/patch
002b338
@shirshanka
fix test
438069a
@shirshanka
Merge remote-tracking branch 'upstream/master' into feat/patch
8f2311e
@shirshanka
attempt fix
291b7cd
@shirshanka
remove metadata-ingestion for now
4922319
@shirshanka
Merge remote-tracking branch 'upstream/master' into feat/patch
56b047d
@shirshanka
quick fix
8237227
@shirshanka
minor refactoring to clean up code path
aac6b6e
@shirshanka
add upstream lineage patch test
9efcde0
@shirshanka shirshanka self-assigned this Sep 23, 2022
@shirshanka shirshanka marked this pull request as ready for review September 23, 2022 01:25
shirshanka
shirshanka approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 0728656 into datahub-project:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees

@shirshanka shirshanka

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RyanHolstien @shirshanka @anshbansal @mayurinehate @hieunt-itfoss @jjoyce0510