Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(feature-guide) Refactor Domains feature guide #5859

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

chriscollins3456
Copy link
Collaborator

Refactors the existing Domains feature guide to follow our new template. Most of the content is still there but just in a new format. Also adds a few new sections and items to follow the template.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Refactors the existing Domains feature guide to follow our new template. Most of the content is still there but just in a new format. Also adds a few new sections and items to follow the template.
@github-actions github-actions bot added the docs Issues and Improvements to docs label Sep 7, 2022
@chriscollins3456 chriscollins3456 changed the title feat(docs) Refactor Domains feature guide docs(feature-guide) Refactor Domains feature guide Sep 7, 2022
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@jjoyce0510 jjoyce0510 merged commit eb16caa into master Sep 9, 2022
@jjoyce0510 jjoyce0510 deleted the chriscollins3456-update-domains-docs branch September 9, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants