Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hive): add column comment as a column description #5449

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix(hive): add column comment as a column description #5449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata-ingestion/docs/sources/hive/hive_recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ source:
type: hive
config:
host_port: <databricks workspace URL>:443
username: token
password: <api token>
username: token / username
password: <api token> / password
scheme: 'databricks+pyhive'

options:
Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/src/datahub/ingestion/source/sql/hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def dbapi_get_columns_patched(self, connection, table_name, schema=None, **kw):
"nullable": True,
"default": None,
"full_type": orig_col_type, # pass it through
"comment": _comment,
}
)
return result
Expand Down