Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protobuf): ownership fixes #5425

Merged
merged 16 commits into from
Jul 18, 2022
Merged

fix(protobuf): ownership fixes #5425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cc6b2c6
Merge pull request #1 from linkedin/master
leifker Mar 2, 2022
dc31cd3
Merge pull request #2 from linkedin/master
leifker Mar 8, 2022
4c9a760
Merge pull request #3 from linkedin/master
leifker Mar 10, 2022
4efc098
Merge pull request #4 from linkedin/master
leifker Mar 11, 2022
175cad1
Merge pull request #5 from linkedin/master
leifker Mar 14, 2022
0b58f4c
Merge pull request #6 from datahub-project/master
leifker Mar 16, 2022
ec29242
Merge branch 'datahub-project:master' into master
leifker Mar 23, 2022
2a14000
Merge branch 'datahub-project:master' into master
leifker Mar 31, 2022
f28eee7
Merge branch 'datahub-project:master' into master
leifker Apr 6, 2022
ed6f123
Merge branch 'datahub-project:master' into master
leifker Apr 8, 2022
ada7eb9
Merge branch 'datahub-project:master' into master
leifker Apr 14, 2022
d4f3719
Merge branch 'datahub-project:master' into master
leifker May 4, 2022
b32b9cb
Merge branch 'datahub-project:master' into master
leifker May 6, 2022
90f0e1d
Merge branch 'datahub-project:master' into master
leifker May 18, 2022
f5dd6fc
Merge branch 'datahub-project:master' into master
leifker Jul 18, 2022
b45b02a
fix(protobuf) Set undeprecated ownership type & fix case sentitive ur…
leifker Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-integration/java/datahub-protobuf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ The following is a consolidated example for the possible field level term option

##### OWNER

One or more owners can be specified and can be any combination of `corpUser` and `corpGroup` entities. The default entity type is `corpGroup`. By default, the ownership type is set to `producer`, see the second example for setting the ownership type.
One or more owners can be specified and can be any combination of `corpUser` and `corpGroup` entities. The default entity type is `corpGroup`. By default, the ownership type is set to `technical_owner`, see the second example for setting the ownership type.

The following example assigns the ownership to a group of `myGroup` and a user called `myName`.

Expand Down
4 changes: 2 additions & 2 deletions ...va/datahub-protobuf/src/main/java/datahub/protobuf/visitors/dataset/OwnershipVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ public Stream<Owner> visitGraph(VisitContext context) {
try {
ownershipType = OwnershipType.valueOf(entry.getKey().getName().toUpperCase());
} catch (IllegalArgumentException e) {
ownershipType = OwnershipType.PRODUCER;
ownershipType = OwnershipType.TECHNICAL_OWNER;
}

String[] id = entry.getValue().toLowerCase().split(":", 2);
return new Owner()
.setType(ownershipType)
.setSource(new OwnershipSource().setType(OwnershipSourceType.MANUAL))
.setOwner(new Urn(id.length > 1 ? id[0] : "corpgroup", id[id.length - 1]));
.setOwner(new Urn(id.length > 1 ? id[0].replaceFirst("corpgroup", "corpGroup") : "corpGroup", id[id.length - 1]));
} catch (URISyntaxException e) {
System.err.println(e.getMessage());
return null;
Expand Down
8 changes: 4 additions & 4 deletions ...atahub-protobuf/src/test/java/datahub/protobuf/visitors/dataset/OwnershipVisitorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ public void visitorTest() throws IOException {
OwnershipVisitor test = new OwnershipVisitor();

assertEquals(Set.of(new Owner()
.setType(OwnershipType.PRODUCER)
.setType(OwnershipType.TECHNICAL_OWNER)
.setSource(new OwnershipSource().setType(OwnershipSourceType.MANUAL))
.setOwner(Urn.createFromTuple("corpgroup", "teamb")),
.setOwner(Urn.createFromTuple("corpGroup", "teamb")),
new Owner()
.setType(OwnershipType.PRODUCER)
.setType(OwnershipType.TECHNICAL_OWNER)
.setSource(new OwnershipSource().setType(OwnershipSourceType.MANUAL))
.setOwner(Urn.createFromTuple("corpuser", "datahub")),
new Owner()
.setType(OwnershipType.TECHNICAL_OWNER)
.setSource(new OwnershipSource().setType(OwnershipSourceType.MANUAL))
.setOwner(Urn.createFromTuple("corpgroup", "technicalowner"))
.setOwner(Urn.createFromTuple("corpGroup", "technicalowner"))
),
graph.accept(getVisitContextBuilder("extended_protobuf.MessageA"), List.of(test)).collect(Collectors.toSet()));
}
Expand Down