Skip to content

fix: Replace old repository link with new link #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjoyce0510 merged 1 commit into from
Mar 18, 2022
Merged

fix: Replace old repository link with new link #4446

jjoyce0510 merged 1 commit into from
Mar 18, 2022

Conversation

@kevinneville
Copy link
Contributor

@kevinneville kevinneville commented Mar 17, 2022 •
edited
Loading

Checklist

  • [x ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka shirshanka added the gold-star :star label Mar 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   47m 41s ⏱️ - 3m 51s
   363 tests ±0     363 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 662 runs  ±0  1 631 ✔️ +7  31 💤  - 7  0 ❌ ±0 

Results for commit 07ad8eb. ± Comparison against base commit 2f078c9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   35m 47s ⏱️ + 21m 16s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 07ad8eb. ± Comparison against base commit 2f078c9.

♻️ This comment has been updated with latest results.

@kevinneville
Copy link
Contributor Author

kevinneville commented Mar 18, 2022 •
edited
Loading

@shirshanka I did a lint fix which I think fixed the failing action. Would you mind triggering it again?

@jjoyce0510
Copy link
Collaborator

jjoyce0510 commented Mar 18, 2022

You are awesome @kevinneville. Thank you so much for the wonderful contribution!

jjoyce0510
jjoyce0510 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjoyce0510 jjoyce0510 merged commit d8e6f89 into datahub-project:master Mar 18, 2022
@kevinneville
Copy link
Contributor Author

kevinneville commented Mar 21, 2022

Thank you!
Not sure what the gold-star label means, but feels good to be the first 🥇

Looking forward to more contributions.

@daha daha mentioned this pull request Apr 1, 2022
Merged
4 tasks
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@kevinneville @maggiehays
fix: Replace old repository link with new link (datahub-project#4446)
9363fa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

No one assigned

Labels

gold-star :star

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinneville @jjoyce0510 @shirshanka