Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible search on soft delete #4405

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Flexible search on soft delete #4405

merged 6 commits into from
Mar 16, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Mar 14, 2022 •
edited
Loading

This PR is a follow-up to #4358 that makes rollback operations, soft-deletes by default.

In particular, this PR updates the cli's delete command with an extra parameter (--include-removed) that includes soft deleted entities in the search result of the entities to be deleted.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   48m 16s ⏱️ + 3m 32s
   363 tests  - 13     363 ✔️ +  4    0 💤 ±0  0 ❌  - 4 
1 662 runs  +  7  1 624 ✔️ +17  38 💤 +7  0 ❌  - 4 

Results for commit 8c533de. ± Comparison against base commit d4d1635.

This pull request removes 13 tests. 
tests.integration.great-expectations.test_great_expectations
tests.integration.hive.test_hive
tests.integration.redshift-usage.test_redshift_usage
tests.integration.starburst-trino-usage.test_starburst_trino_usage
tests.integration.trino.test_trino
tests.unit.stateful_ingestion.provider.test_datahub_ingestion_checkpointing_provider
tests.unit.stateful_ingestion.provider.test_datahub_ingestion_reporting_provider
tests.unit.stateful_ingestion.state.test_checkpoint
tests.unit.test_great_expectations_action
tests.unit.test_mariadb_source
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   15m 46s ⏱️ +43s
674 tests +1  615 ✔️ +1  59 💤 ±0  0 ❌ ±0 

Results for commit 8c533de. ± Comparison against base commit d4d1635.

♻️ This comment has been updated with latest results.

rslanka
rslanka suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in the comments.

@pedro93 pedro93 requested a review from rslanka March 16, 2022 15:51
rslanka
rslanka approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedro93 pedro93 closed this Mar 16, 2022
@pedro93 pedro93 reopened this Mar 16, 2022
@gabe-lyons gabe-lyons merged commit aa593c3 into datahub-project:master Mar 16, 2022
@pedro93 pedro93 deleted the pedro/flexible-search-on-soft-delete branch March 16, 2022 23:35
@pedro93 pedro93 mentioned this pull request Mar 24, 2022
Merged
4 tasks
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@pedro93 @maggiehays
Flexible search on soft delete (datahub-project#4405)
84fcf31 
* Adds filter logic to correct DB

* Fix build

* Adds documentation & fixes flag typo

* apply review comments

* Adds test for filtered search

* Adds warning log for redundant parameter combo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@rslanka rslanka rslanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees

@dexter-mh-lee dexter-mh-lee

@rslanka rslanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pedro93 @dexter-mh-lee @rslanka @jjoyce0510 @gabe-lyons