feat(quickstart): restart actions pod in case of failures #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Mar 8, 2022
|
For one case it was an air-gapped environment which will be fixed when we merge in https://github.com/linkedin/datahub/pull/4350/files, release datahub cli, make change in actions, do a release, update quickstart in datahub In general I think there should be retries in our compose files in case something crashes. |
shirshanka
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes actions pod fails. We should restart it a few times to improve user experience.
The format used is undocumented but works as per https://stackoverflow.com/questions/42216017/docker-compose-restart-policy#comment100592024_43006595
Checklist