ci(cypress): adding the foundation for cypress integration tests & some starter coverage for login, search & updates #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
its running!
|
jjoyce0510
reviewed
Dec 13, 2021
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "name": "Using fixtures to represent data", | |||
| "email": "[email protected]", | |||
Contributor
Author
There was a problem hiding this comment.
this is an example fixture generated by default by cypress- its just showing someone how they might add another fixture
jjoyce0510
reviewed
Dec 13, 2021
| cy.deleteUrn('urn:li:tag:CypressTestAddTag') | ||
| cy.login(); | ||
| cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,cypress_logging_events,PROD)'); | ||
| cy.contains('cypress_logging_events'); |
Collaborator
There was a problem hiding this comment.
or is this indentional?
jjoyce0510
reviewed
Dec 13, 2021
| // | ||
| // | ||
| // -- This is a parent command -- | ||
| Cypress.Commands.add('login', () => { |
jjoyce0510
reviewed
Dec 13, 2021
| ] | ||
| } | ||
| }, | ||
| "proposedDelta": null |
jjoyce0510
reviewed
Dec 13, 2021
| proc = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE, cwd="tests/cypress") | ||
| stdout = proc.stdout.read() | ||
| stderr = proc.stderr.read() | ||
| return_code = proc.wait() |
jjoyce0510
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the groundwork for adding more cypress tests in the future. This PR gives an demonstration of how:
I also tested w/ a failing test earlier (before fix dataset name assertion) and verified that cypress outputs a very human-readable response when the test fails.
Checklist