-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(auth): Metadata Service Authentication! #3598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shirshanka
merged 29 commits into
datahub-project:master
from
jjoyce0510:metadata-service-auth
Nov 23, 2021
Merged
feat(auth): Metadata Service Authentication! #3598
shirshanka
merged 29 commits into
datahub-project:master
from
jjoyce0510:metadata-service-auth
Nov 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjoyce0510
commented
Nov 19, 2021
jjoyce0510
commented
Nov 19, 2021
gabe-lyons
reviewed
Nov 19, 2021
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Show resolved
Hide resolved
...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/auth/GetAccessTokenResolver.java
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Nov 19, 2021
gabe-lyons
approved these changes
Nov 22, 2021
shirshanka
approved these changes
Nov 23, 2021
Contributor
shirshanka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited for the future of Authentication in DataHub. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces optional Authentication of requests to the Metadata Service Layer. By default, this feature is disabled but it can be enabled using the METADATA_SERVICE_AUTH_ENABLED env variable for the datahub-frontend & datahub-gms containers / pods.
This PR description will provide a brief outline of the changes. Read a full summary of these changes here.
Changes
New Components
New Features (UI)
Refactoring
metadata-service:graphql-apimodule tometadata-service:graphql-servlet-implto more accurately reflect its contents.metadata-service:restli-implmodule tometadata-service:restli-servlet-implto more accurately reflect its contents.Compatibility
Fully compatible.
Status
Mostly ready for review
Screenshots
Checklist