Skip to content

Conversation

@jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Nov 19, 2021

Summary
This PR introduces optional Authentication of requests to the Metadata Service Layer. By default, this feature is disabled but it can be enabled using the METADATA_SERVICE_AUTH_ENABLED env variable for the datahub-frontend & datahub-gms containers / pods.

This PR description will provide a brief outline of the changes. Read a full summary of these changes here.

Changes

New Components

  • Most important: Actor, AuthenticationChain, Authenticator, TokenService, AccessToken
  • New Auth Servlet in Metadata Service (/auth) for serving generated access tokens

New Features (UI)

  • Now supporting generation of Personal Access Tokens that can be used to make authenticated, programmatic requests to DataHub APIs. Find this under a new 'Settings' tab in the UI.

Refactoring

  • Remove usage of RestliEntityClient in GraphQL server, replacement with JavaEntityClient + Entity interface
  • Renamed metadata-service:graphql-api module to metadata-service:graphql-servlet-impl to more accurately reflect its contents.
  • Renamed metadata-service:restli-impl module to metadata-service:restli-servlet-impl to more accurately reflect its contents.
  • Misc. minor naming, annotations changes.

Compatibility
Fully compatible.

Status
Mostly ready for review

Screenshots

Screen Shot 2021-11-18 at 1 42 30 PM

Screen Shot 2021-11-18 at 1 42 40 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 changed the title Metadata Service Authentication! feat(auth): Metadata Service Authentication! Nov 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2021

Unit Test Results

     41 files  +  4       41 suites  +4   27m 22s ⏱️ -24s
   610 tests +19     558 ✔️ +19  52 💤 ±0  0 ±0 
1 347 runs  +17  1 273 ✔️ +11  74 💤 +6  0 ±0 

Results for commit 796b0ab. ± Comparison against base commit fde42e0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited for the future of Authentication in DataHub. LGTM!

@shirshanka shirshanka merged commit f49666a into datahub-project:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants