Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion): Update pyyaml #2365

Merged
merged 1 commit into from
Apr 8, 2021
Merged

feat(ingestion): Update pyyaml #2365

merged 1 commit into from
Apr 8, 2021

Conversation

frsann
Copy link
Contributor

@frsann frsann commented Apr 8, 2021 •
edited
Loading

We update pyyaml to >=5.4 as lower version includes a vulnerability and our dependabot doesn't like it.

Unfortunatley, I dont have a easy way of testing this. Ping @grantatspothero.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@frsann frsann force-pushed the fix/update-pyyaml branch from ae6b3f2 to 0c7c67f Compare April 8, 2021 13:49
hsheth2
hsheth2 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the yaml format hasn't changed much, so it's likely still compatible

shirshanka
shirshanka approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit f837360 into datahub-project:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frsann @shirshanka @hsheth2