Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): make es-setup job parameters more contextual #2313

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix(k8s): make es-setup job parameters more contextual #2313

merged 1 commit into from
Mar 31, 2021

Conversation

shakti-garg
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

resolves #2301

@shakti-garg
Copy link
Contributor Author

shakti-garg commented Mar 30, 2021 •
edited
Loading

@shirshanka On second look to the code today, i found parameter names bit inconsistent. This PR is to make their names more contextual and consistent.

Sorry for not being so thoughtful on first time!

shirshanka
shirshanka approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 1a62813 into datahub-project:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(kubernetes): Add kubernetes hook for elasticsearch-setup
3 participants
@shakti-garg @dexter-mh-lee @shirshanka