feat: Add Elasticsearch 7 support #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parameters in search query are optional and automatically populated. With the ES upgrade these parameters could be removed/added.
| @@ -22,18 +22,17 @@ | |||
| "fuzzy_transpositions" : true, | |||
| "lenient" : false, | |||
| "zero_terms_query" : "NONE", | |||
| "auto_generate_synonyms_phrase_query": true, | |||
There was a problem hiding this comment.
Similar question: what is the default value for this?
There was a problem hiding this comment.
(Optional, Boolean) If true, match phrase queries are automatically created for multi-term synonyms. Defaults to true. See Synonyms for an example.
I don't know why this was added, I copied it from Jyoti's PR. I can remove it and see what happens?
There was a problem hiding this comment.
Ah, this is in test data. Yes, I'm guessing the ES java library makes some defaults explicit.
camelliazhang
approved these changes
Feb 10, 2021
|
fyi @cobolbaby |
jplaisted
pushed a commit
that referenced
this pull request
Mar 19, 2021
* upgrade to ES7 * add doc summarizing the changes * Call out the optional parameters in search query Some parameters in search query are optional and automatically populated. With the ES upgrade these parameters could be removed/added. * revert unrelated changes * update required max_ngram_diff field for ES7 (caught by integration tests) Co-authored-by: Jyoti Wadhwani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from https://github.com/linkedin/datahub/pull/1997/files
This is now tested with the integration test framework :)
Checklist