refactor(React Incubation): Entity Interface & EntityRegistry#2077
Merged
shirshanka merged 4 commits intodatahub-project:masterfrom Feb 3, 2021
Merged
refactor(React Incubation): Entity Interface & EntityRegistry#2077shirshanka merged 4 commits intodatahub-project:masterfrom
shirshanka merged 4 commits intodatahub-project:masterfrom
Conversation
Introducing the Entity Registry: an Entity-oriented Architecture Co-authored-by: John Joyce <[email protected]>
woodyzhou
reviewed
Feb 2, 2021
gabe-lyons
reviewed
Feb 2, 2021
gabe-lyons
approved these changes
Feb 2, 2021
shirshanka
approved these changes
Feb 3, 2021
Contributor
shirshanka
left a comment
shirshanka
left a comment
There was a problem hiding this comment.
Thanks for the great feedback @igbopie, @woodyzhou and @gabe-lyons!
LGTM now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces 2 concepts into the incubating React app:
EntityInterface: Defines a set of methods implemented by every top-level UI entity shown in the UI (Dataset, CorpUser, etc). These methods are used to signal which features are enabled for a particular entity (browse, search) as well as providing functions for rendering views across feature verticals. (Examples:DatasetEntity,UserEntity)EntityRegistry: A singleton class provided via React Context to all components which serves as the source of truth for instances of theEntityinterface.(Also included some minor refactorings)
Architecture
Notes
As the app is still in active incubation, this architecture is subject to change.
Checklist