Skip to content

feat: add elasticsearch sanity integration tests #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jplaisted merged 1 commit into from
Dec 3, 2020
Merged

feat: add elasticsearch sanity integration tests #2028

jplaisted merged 1 commit into from
Dec 3, 2020

Conversation

@jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Dec 2, 2020 •
edited
Loading

These tests verify that, given an index settings and mappings, data can be written to the index, and read from it with a query_all query. These are very simple sanity tests.

We can, and should, write more complex tests that specific to each index in the future.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

feat: add elasticsearch sanity integration tests
272b387 
These tests verify that, given an index settings and mappings, data can be written to the index, and read from it with a query_all query. These are very simple sanity tests.

We can, and should, write more complex tests that specific to each index in the future.
@jplaisted jplaisted requested a review from woodyzhou December 2, 2020 20:11
woodyzhou
woodyzhou approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@woodyzhou woodyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jplaisted jplaisted merged commit 838f964 into datahub-project:master Dec 3, 2020
@jplaisted jplaisted deleted the searchTests branch December 3, 2020 04:49
@nagarjunakanamarlapudi nagarjunakanamarlapudi mentioned this pull request Dec 14, 2020
Closed
nagarjunakanamarlapudi added a commit to nagarjunakanamarlapudi/datahub that referenced this pull request Dec 14, 2020
@nagarjunakanamarlapudi
fix(search): Fix the rollback unintentional rollback(datahub-project#…
c00d1b0 
…2028) of dataset index to search by field paths.
@nagarjunakanamarlapudi nagarjunakanamarlapudi mentioned this pull request Dec 15, 2020
Merged
4 tasks
nagarjunakanamarlapudi added a commit that referenced this pull request Dec 15, 2020
@nagarjunakanamarlapudi
fix(search): Fix the rollback unintentional rollback(#2028) of datase…
0fef73b 
…t index to search by field paths. (#2040)

Enables the auto complete of field paths on DataHub UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@woodyzhou woodyzhou woodyzhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jplaisted @woodyzhou