Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CODEOWNERS file. #2021

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add a CODEOWNERS file. #2021

merged 3 commits into from
Dec 1, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Nov 30, 2020 •
edited
Loading

After this we can enforce that reviews must be approved by people on this list.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Add a CODEOWNERS file.
eb79e15 
After this we can enforce that reviews must be approved by people on this list.
@jplaisted jplaisted requested a review from woodyzhou November 30, 2020 22:31
woodyzhou
woodyzhou approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@woodyzhou woodyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jplaisted jplaisted merged commit 8ab4e93 into datahub-project:master Dec 1, 2020
@jplaisted jplaisted deleted the owners branch December 1, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodyzhou woodyzhou woodyzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplaisted @woodyzhou