Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Dashboards backend implementation #1884

Merged
merged 6 commits into from
Nov 23, 2020
Merged

feat(dashboard): Dashboards backend implementation #1884

merged 6 commits into from
Nov 23, 2020

Conversation

keremsahin1
Copy link
Contributor

@keremsahin1 keremsahin1 commented Sep 21, 2020 •
edited
Loading

Manually done the integration tests after running dev Dockers.

  1. Ingested sample data for both chart and dashboard entities through ingest endpoint.
  2. Checked ingested data through get and get_all endpoints.
  3. Tested search & autocomplete endpoints.
  4. Checked Neo4j graph to see if nodes & edges are generated as expected.

Also tested and validated the MCE ingestion pipeline by emitting sample MCEs using mce_cli.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mars-lan
Copy link
Contributor

@grantatspothero you may be interested in reviewing this.

@keremsahin1 keremsahin1 mentioned this pull request Oct 9, 2020
Closed
@keremsahin1 keremsahin1 mentioned this pull request Oct 27, 2020
Merged
4 tasks
shirshanka
shirshanka approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 4d8320e into datahub-project:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplaisted jplaisted jplaisted requested changes

@grantatspothero grantatspothero grantatspothero left review comments

@mars-lan mars-lan mars-lan requested changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keremsahin1 @mars-lan @shirshanka @jplaisted @grantatspothero