Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove helm container commands #1697

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

jsotelo
Copy link
Contributor

@jsotelo jsotelo commented Jun 11, 2020

Some of the current helm container commands are not compatible with the latest
docker images. Instead, rely on CMD in the docker images.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

The current helm command is not compatible with the
docker image. Instead, rely on the docker image's CMD.
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mars-lan mars-lan merged commit e7be6db into datahub-project:master Jun 11, 2020
@jsotelo jsotelo deleted the fix/helm branch June 11, 2020 17:51
mars-lan pushed a commit to mars-lan/datahub that referenced this pull request Jun 25, 2020
The current helm command is not compatible with the
docker image. Instead, rely on the docker image's CMD.

Co-authored-by: jsotelo <[email protected]>
chriscollins3456 added a commit to chriscollins3456/datahub that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants