Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: points to docker images hosted by linkedin org #1683

Merged
merged 1 commit into from
Jun 1, 2020
Merged

docs: points to docker images hosted by linkedin org #1683

merged 1 commit into from
Jun 1, 2020

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented May 30, 2020 •
edited
Loading

As we're now utilize GitHub Actions to build & publish docker images to docker hub under linkedin org
Closes #1548

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mars-lan mars-lan changed the title doc: points to docker images hosted by linkedin org docs: points to docker images hosted by linkedin org May 30, 2020
@mars-lan mars-lan requested a review from keremsahin1 May 30, 2020 01:07
@mars-lan mars-lan requested a review from jywadhwani May 30, 2020 01:08
keremsahin1
keremsahin1 suggested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see lots of hits for keremsahin/ under contrib/kubernetes. I think we can also safely change them to linkedin/?

@mars-lan
docs: points to docker images hosted by linkedin org
74b872c 
As we're now utilize GitHub Actions to build & publish docker images to docker hub under linkedin org
Also allow overriding image tags via DATAHUB_VERSION environment variable
@mars-lan
Copy link
Contributor Author

mars-lan commented Jun 1, 2020

I see lots of hits for keremsahin/ under contrib/kubernetes. I think we can also safely change them to linkedin/?

Updated

jywadhwani
jywadhwani approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@jywadhwani jywadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@mars-lan mars-lan merged commit 920a177 into datahub-project:master Jun 1, 2020
mars-lan added a commit to mars-lan/datahub that referenced this pull request Jun 25, 2020
@mars-lan
docs: points to docker images hosted by linkedin org (datahub-project…
ea2377d 
…#1683)

As we're now utilize GitHub Actions to build & publish docker images to docker hub under linkedin org
Also allow overriding image tags via DATAHUB_VERSION environment variable
chriscollins3456 pushed a commit to chriscollins3456/datahub that referenced this pull request Sep 14, 2023
@joshuaeilers
chore(nested-domains): list and create tests (datahub-project#1683)
0fbc505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywadhwani jywadhwani jywadhwani approved these changes

@keremsahin1 keremsahin1 keremsahin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Docker containers under /linkedin or /datahub account
3 participants
@mars-lan @keremsahin1 @jywadhwani