feat(ingestion): use approx_distinct when profiling Athena and Trino #13671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
Bundle ReportChanges will decrease total bundle size by 355 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
ec76fa7 to
3a3703f
Compare
hsheth2
reviewed
Jun 2, 2025
metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py
Outdated
Show resolved
Hide resolved
| expr = sa.func.APPROX_COUNT_DISTINCT(sa.column(column)) | ||
| elif ( | ||
| self.engine.dialect.name.lower() == AWSATHENA | ||
| or self.engine.dialect.name.lower() == TRINO |
Contributor
There was a problem hiding this comment.
do we have trino tests that validate this logic?
Contributor
Author
There was a problem hiding this comment.
Yes, the Trino integration tests include profiling of unique counts. Most of the unique counts in the test data are small and unchanged.
One difference that came up: approx_distinct can process JSON-typed columns whereas count(DISTINCT ...) errors out. So more stats will now be available for JSON columns!
Having a unique count also triggers distinct unique value frequency profiling in cases of low cardinality. That logic didn't have any exception handling, and failed trying to SORT BY a JSON column. I included fixes for both of these issues in the PR.
datahub-cyborg
bot
added
pending-submitter-response
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
3a3703f to
21d0c32
Compare
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
21d0c32 to
752cf71
Compare
datahub-cyborg
bot
added
needs-review
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
752cf71 to
94d914a
Compare
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
94d914a to
885b60b
Compare
hsheth2
approved these changes
Jun 23, 2025
datahub-cyborg
bot
added
merge-pending-ci
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
885b60b to
be703c2
Compare
…nct_value_frequencies Great Expectations runs SORT BY in SQL by default, but not all column types are sortable (such as JSON data types on Athena/Trino). We could pass sort="none" and sort it in Python instead, but writing the SQL ourselves is straightforward and seems less bug-prone than relying on stringly-typed arguments into an external library.
ligfx
force-pushed
the
athena_profiling_approx_distinct
branch
from
be703c2 to
6780a22
Compare
anshbansal
pushed a commit
that referenced
this pull request
Jun 27, 2025
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.