Skip to content

Updated drawer to match entity drawer styling #13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annadoesdesign merged 3 commits into from
Jun 9, 2025
Merged

Updated drawer to match entity drawer styling #13665

annadoesdesign merged 3 commits into from
Jun 9, 2025

Conversation

@annadoesdesign
Copy link
Contributor

@annadoesdesign annadoesdesign commented May 30, 2025

Updated schema drawer:
Tabs
Borders / Dividers
Before

Screenshot 2025-05-30 at 8 50 10 AM After Screenshot 2025-05-30 at 8 49 37 AM Screenshot 2025-05-30 at 8 49 35 AM Screenshot 2025-05-30 at 8 49 36 AM Screenshot 2025-05-30 at 8 49 32 AM

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 30, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 30, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented May 30, 2025 •
edited
Loading

🔴 Meticulous spotted visual differences in 28 of 1492 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 057e369. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 5.88kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.66MB 5.88kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 5.88kB 16.04MB 0.04%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/FieldDetails.tsx → Total Size: 4.0kB

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/FieldHeader.tsx → Total Size: 3.27kB

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/SchemaFieldDrawerTabs.tsx → Total Size: 6.5kB

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/SchemaFieldDrawer.tsx → Total Size: 7.3kB

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/components.ts → Total Size: 285 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/StatsSidebarContent.tsx → Total Size: 5.01kB

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/AboutFieldTab.tsx → Total Size: 2.7kB

@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.70035% with 64 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...onents/SchemaFieldDrawer/SchemaFieldDrawerTabs.tsx 76.66% 63 Missing ⚠️
...ema/components/SchemaFieldDrawer/AboutFieldTab.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

anthonyburdi
anthonyburdi reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's see if we can reduce/remove the use of !important

...p/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/SchemaFieldDrawerTabs.tsx Outdated
margin: 8px 8px 16px 8px;
border-radius: 6px;
padding: 0;
margin: 0 0 4px 0 !important;
Copy link
Contributor

@anthonyburdi anthonyburdi Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can reduce / remove the use of !important throughout this file? It could make debugging harder down the road. If we need them to override antd maybe there isn't a way around it but let me know what you think!

Copy link
Contributor Author

@annadoesdesign annadoesdesign Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! ill take care of this!!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jun 2, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jun 3, 2025
anthonyburdi
anthonyburdi approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jun 4, 2025
@annadoesdesign annadoesdesign merged commit c997668 into master Jun 9, 2025
31 of 33 checks passed
@annadoesdesign annadoesdesign deleted the ae--DES-384-update-schema-field-drawer branch June 9, 2025 15:12
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
@annadoesdesign @kartikey-visa
Updated drawer to match entity drawer styling (datahub-project#13665)
8624dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annadoesdesign @anthonyburdi