feat(application): Adding application entity models, apis, search and entity page. #13660

gabe-lyons · 2025-05-29T23:54:48Z

The first phase in delivering Application as an entity.

Next steps:

Sidebar section for entities, gated by feature flag controllable from Admin UI, default off to prevent additional noise for the UI for most users.
Being able to add entities to Application from Application entity page
~~Application as a dropdown filter in search~~
Being able to create new Applications from a root Application management page.

Entity page:

In search:

codecov · 2025-05-29T23:57:29Z

Codecov Report

Attention: Patch coverage is 41.20830% with 652 lines in your changes missing coverage. Please review.

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.opensearch.SearchGraphServiceOpenSearchTest.xml at 117:1052

Caused by:
    RuntimeError: Error converting computed name to ValidatedString
    
    Caused by:
        string is too long
For more help, visit our troubleshooting guide.

Files with missing lines	Patch %	Lines
...t/src/app/entity/application/ApplicationEntity.tsx	35.00%	169 Missing ⚠️
...src/app/entityV2/application/ApplicationEntity.tsx	35.63%	168 Missing ⚠️
...ct/src/app/entityV2/application/AssetsSections.tsx	32.32%	67 Missing ⚠️
...l/types/application/mappers/ApplicationMapper.java	0.00%	45 Missing ⚠️
...t/src/app/entityV2/application/preview/Preview.tsx	40.27%	43 Missing ⚠️
...hub/graphql/types/application/ApplicationType.java	0.00%	29 Missing ⚠️
.../linkedin/metadata/service/ApplicationService.java	76.10%	25 Missing and 2 partials ⚠️
...pp/entityV2/application/ApplicationEntitiesTab.tsx	25.00%	24 Missing ⚠️
...ql/resolvers/mutate/UpdateDescriptionResolver.java	0.00%	17 Missing ⚠️
...com/linkedin/datahub/graphql/GmsGraphQLEngine.java	0.00%	13 Missing ⚠️
... and 10 more

❌ Your patch status has failed because the patch coverage (41.20%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

alwaysmeticulous · 2025-05-30T00:07:30Z

🔴 Meticulous spotted visual differences in 407 of 1502 screens tested: view and approve differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

_{Last updated for commit 1385ed5. This comment will update as new commits are pushed.}

codecov · 2025-05-30T00:14:49Z

Bundle Report

Changes will increase total bundle size by 10.68kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	19.67MB	10.68kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	10.68kB	16.04MB	0.07%

Files in assets/index-*.js:

./src/app/buildEntityRegistry.ts → Total Size: 1.43kB
./src/app/entityV2/application/ApplicationEntitiesTab.tsx → Total Size: 535 bytes
./src/app/buildEntityRegistryV2.ts → Total Size: 1.41kB
./src/app/entity/application/ApplicationEntity.tsx → Total Size: 5.72kB
./src/app/entityV2/application/ApplicationSummaryTab.tsx → Total Size: 260 bytes
./src/app/entityV2/application/ApplicationEntity.tsx → Total Size: 5.83kB
./src/app/entityV2/application/AssetsSections.tsx → Total Size: 2.33kB

sgomezvillamor · 2025-06-05T06:36:17Z

metadata-models/src/main/resources/entity-registry.yml

+  - name: application
+    category: core
+    keyAspect: applicationKey
+    aspects:


should dataPlatformInstance be included too?
not sure about the scope of Application, so just raising the question to make sure it's not overlooked

I don't think that should be necessary based on what we've heard so far.

david-leifker · 2025-06-06T02:31:40Z

Merge-able once CI is green of course

… entity page. (datahub-project#13660)

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels May 29, 2025

github-actions bot deployed to datahub-wheels (Preview) May 29, 2025 23:58 View deployment

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 30, 2025

vercel bot had a problem deploying to Preview May 30, 2025 00:04 Failure

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 00:06 View deployment

github-actions bot deployed to datahub-wheels (Preview) May 30, 2025 13:34 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 13:44 Failure

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 13:54 View deployment

vercel bot had a problem deploying to Preview May 31, 2025 00:14 Failure

gabe-lyons added 5 commits June 3, 2025 13:43

react/frontend for application

de75524

graphql & backend + models

6a5b619

fixing yarn lint

85150dc

adding ApplicationServiceTest.java

0526ad9

removing unused file

ebdf684

gabe-lyons force-pushed the adding-application-entity branch from ae1e40d to ebdf684 Compare June 3, 2025 20:47

github-actions bot deployed to datahub-wheels (Preview) June 3, 2025 20:49 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 3, 2025 20:57 View deployment

vercel bot had a problem deploying to Preview June 3, 2025 21:01 Failure

updating tests and permissions

90f3cef

github-actions bot deployed to datahub-wheels (Preview) June 4, 2025 22:59 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 4, 2025 23:08 View deployment

vercel bot had a problem deploying to Preview June 4, 2025 23:10 Failure

gabe-lyons changed the title ~~[WIP] Adding application entity models, apis, search and entity page.~~ feat(application): Adding application entity models, apis, search and entity page. Jun 5, 2025

sgomezvillamor reviewed Jun 5, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jun 5, 2025

Fixing lint and referntial delete

62cc913

github-actions bot deployed to datahub-wheels (Preview) June 6, 2025 14:11 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 6, 2025 14:17 View deployment

vercel bot had a problem deploying to Preview June 6, 2025 14:19 Failure

gabe-lyons added 2 commits June 8, 2025 18:06

fixing application lint

f7d5584

ci failure fixes

7582151

github-actions bot deployed to datahub-wheels (Preview) June 9, 2025 01:08 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 9, 2025 01:19 View deployment

vercel bot had a problem deploying to Preview June 9, 2025 01:20 Failure

lint fix

ef688b7

github-actions bot deployed to datahub-wheels (Preview) June 9, 2025 01:48 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 9, 2025 01:57 View deployment

vercel bot had a problem deploying to Preview June 9, 2025 02:00 Failure

prettier

d8b5558

github-actions bot deployed to datahub-wheels (Preview) June 9, 2025 03:52 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 9, 2025 04:02 View deployment

vercel bot had a problem deploying to Preview June 9, 2025 04:04 Failure

adding v1

b1854cb

github-actions bot deployed to datahub-wheels (Preview) June 9, 2025 13:12 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 9, 2025 13:17 View deployment

vercel bot had a problem deploying to Preview June 9, 2025 13:18 Failure

fixing test

1385ed5

github-actions bot deployed to datahub-wheels (Preview) June 9, 2025 13:25 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 9, 2025 13:32 View deployment

vercel bot had a problem deploying to Preview June 9, 2025 13:50 Failure

gabe-lyons merged commit c913aa4 into master Jun 9, 2025
77 of 80 checks passed

gabe-lyons deleted the adding-application-entity branch June 9, 2025 14:12

gabe-lyons mentioned this pull request Jun 10, 2025

fix(application): adjusting applicatino to new search signature #13742

Merged

kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025

feat(application): Adding application entity models, apis, search and…

fa7d409

… entity page. (datahub-project#13660)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(application): Adding application entity models, apis, search and entity page. #13660

feat(application): Adding application entity models, apis, search and entity page. #13660

Uh oh!

gabe-lyons commented May 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 29, 2025 •

edited

Loading

Uh oh!

alwaysmeticulous bot commented May 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Assets Changed:

Uh oh!

sgomezvillamor Jun 5, 2025

Uh oh!

gabe-lyons Jun 5, 2025

Uh oh!

david-leifker commented Jun 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(application): Adding application entity models, apis, search and entity page. #13660

feat(application): Adding application entity models, apis, search and entity page. #13660

Uh oh!

Conversation

gabe-lyons commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

❌ Unsupported file format

Uh oh!

alwaysmeticulous bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

sgomezvillamor Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

gabe-lyons Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

david-leifker commented Jun 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabe-lyons commented May 29, 2025 •

edited

Loading

codecov bot commented May 29, 2025 •

edited

Loading

alwaysmeticulous bot commented May 30, 2025 •

edited

Loading

codecov bot commented May 30, 2025 •

edited

Loading