feat(ui/ingestion): add empty and loading states for sources and secrets tables #13646

purnimagarg1 · 2025-05-28T13:17:33Z

Linear tickets:
https://linear.app/acryl-data/issue/CH-372/add-empty-and-loading-states-for-ingestion-table
https://linear.app/acryl-data/issue/CH-378/change-copy-in-execution-run-modal

Description:

Adds empty and loading states for Sources and Secrets tabs in ingestion
Updates copy from "Sync Details" to "Execution Run Details" in the modal
Use the modal component from library in ExecutionRequestDetailsModal

Screenshots:

alwaysmeticulous · 2025-05-28T13:27:39Z

🔴 Meticulous spotted visual differences in 90 of 1354 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

_{Last updated for commit 0b77ef2. This comment will update as new commits are pushed.}

codecov · 2025-05-28T13:39:37Z

Codecov Report

Attention: Patch coverage is 23.96694% with 92 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...-web-react/src/app/ingestV2/secret/SecretsList.tsx	8.57%	32 Missing ⚠️
...ct/src/app/ingestV2/source/IngestionSourceList.tsx	3.33%	29 Missing ⚠️
...atahub-web-react/src/app/ingestV2/EmptySources.tsx	50.00%	22 Missing ⚠️
...source/executions/ExecutionRequestDetailsModal.tsx	33.33%	4 Missing ⚠️
...source/executions/ExecutionRequestDetailsModal.tsx	0.00%	3 Missing ⚠️
...t/src/app/ingestV2/source/IngestionSourceTable.tsx	33.33%	2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (23.96%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

sakethvarma397 · 2025-05-28T14:24:44Z

datahub-web-react/src/app/ingestV2/secret/SecretsList.tsx

@@ -1,19 +1,19 @@
 import { Icon, Pagination, SearchBar, Table, colors } from '@components';
-import { Empty, Modal, Typography, message } from 'antd';
+import { Modal, Typography, message } from 'antd';


We could remove this antd modal as well. I think ConfirmationModal would work for this use-case

sakethvarma397 · 2025-05-28T14:48:35Z

datahub-web-react/src/app/ingestV2/EmptySources.tsx

+const EmptySources = ({ sourceType, isEmptySearch }: Props) => {
+    return (
+        <EmptyContainer>
+            {isEmptySearch ? (


Should this be other way round?
It still works here because we are doing !!query but it should be !query to be aligned with the variable name.

chriscollins3456

looking solid just agreed with saketh's comments then i think we're good to go!

chriscollins3456 · 2025-05-29T17:34:31Z

datahub-web-react/src/app/ingestV2/secret/SecretsList.tsx

-                {tableData.length === 0 ? (
-                    <EmptyState />
+                {!loading && totalSecrets === 0 ? (
+                    <EmptySources sourceType="secrets" isEmptySearch={!!query} />


yeah agreed with saketh that isEmptySearch and !!query don't match - isEmptySearch should mean there's no query? regardless i think we should make this a little clearer

this is denote when a search returns empty state. I'll change the name to isEmptySearchResult

In fact we're using isEmptySearch to denote the same scenario at multiple other places. Maybe we can change the prop name everywhere.

codecov · 2025-05-30T15:30:38Z

Bundle Report

Changes will increase total bundle size by 437 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	19.65MB	437 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	437 bytes	16.02MB	0.0%

Files in assets/index-*.js:

./src/app/ingestV2/secret/SecretsList.tsx → Total Size: 8.73kB
./src/app/ingestV2/source/IngestionSourceTable.tsx → Total Size: 2.44kB
./src/app/ingestV2/EmptySources.tsx → Total Size: 985 bytes
./src/app/ingest/source/executions/ExecutionRequestDetailsModal.tsx → Total Size: 7.7kB
./src/app/ingestV2/source/executions/ExecutionRequestDetailsModal.tsx → Total Size: 7.46kB
./src/app/ingestV2/source/IngestionSourceList.tsx → Total Size: 14.15kB

… component

chriscollins3456

nice!

…ets tables (datahub-project#13646) Co-authored-by: Chris Collins <[email protected]>

github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 28, 2025

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 28, 2025

github-actions bot deployed to datahub-project-web-react (Preview) May 28, 2025 13:27 View deployment

vercel bot deployed to Preview May 28, 2025 13:39 View deployment

sakethvarma397 reviewed May 28, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 28, 2025

sakethvarma397 reviewed May 28, 2025

View reviewed changes

chriscollins3456 reviewed May 29, 2025

View reviewed changes

datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 30, 2025

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 12:46 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 12:51 Failure

purnimagarg1 force-pushed the CH-365-update-secrets-tab branch from 8b69ba0 to a9cd919 Compare May 30, 2025 15:17

purnimagarg1 force-pushed the CH-372-empty-loading-state-ingestion-table branch from aa69369 to 3feee4f Compare May 30, 2025 15:22

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 15:31 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 15:36 Failure

chriscollins3456 force-pushed the CH-365-update-secrets-tab branch from a9cd919 to 9804942 Compare May 30, 2025 19:53

Base automatically changed from CH-365-update-secrets-tab to master May 30, 2025 20:42

purnimagarg1 added 3 commits May 30, 2025 16:45

add empty and loading states for sources and secrets tables

6aebc1c

Updates copy from Sync Details to Execution Run Details and use modal…

d6e8e6b

… component

replace modal and rename prop

23bbca9

chriscollins3456 force-pushed the CH-372-empty-loading-state-ingestion-table branch from 3feee4f to 23bbca9 Compare May 30, 2025 20:46

chriscollins3456 approved these changes May 30, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 30, 2025

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 21:04 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 21:19 Failure

Merge branch 'master' into CH-372-empty-loading-state-ingestion-table

0b77ef2

github-actions bot deployed to datahub-project-web-react (Preview) May 31, 2025 00:11 View deployment

vercel bot had a problem deploying to Preview May 31, 2025 00:15 Failure

chriscollins3456 merged commit 2620af8 into master May 31, 2025
30 of 33 checks passed

chriscollins3456 deleted the CH-372-empty-loading-state-ingestion-table branch May 31, 2025 00:44

kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025

feat(ui/ingestion): add empty and loading states for sources and secr…

eef8582

…ets tables (datahub-project#13646) Co-authored-by: Chris Collins <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ui/ingestion): add empty and loading states for sources and secrets tables #13646

feat(ui/ingestion): add empty and loading states for sources and secrets tables #13646

Uh oh!

purnimagarg1 commented May 28, 2025

Uh oh!

alwaysmeticulous bot commented May 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 28, 2025 •

edited

Loading

Uh oh!

sakethvarma397 May 28, 2025

Uh oh!

sakethvarma397 May 28, 2025

Uh oh!

chriscollins3456 left a comment

Uh oh!

chriscollins3456 May 29, 2025

Uh oh!

purnimagarg1 May 30, 2025

Uh oh!

purnimagarg1 May 30, 2025

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Assets Changed:

Uh oh!

chriscollins3456 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(ui/ingestion): add empty and loading states for sources and secrets tables #13646

feat(ui/ingestion): add empty and loading states for sources and secrets tables #13646

Uh oh!

Conversation

purnimagarg1 commented May 28, 2025

Uh oh!

alwaysmeticulous bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sakethvarma397 May 28, 2025

Choose a reason for hiding this comment

Uh oh!

sakethvarma397 May 28, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 May 29, 2025

Choose a reason for hiding this comment

Uh oh!

purnimagarg1 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

purnimagarg1 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alwaysmeticulous bot commented May 28, 2025 •

edited

Loading

codecov bot commented May 28, 2025 •

edited

Loading

codecov bot commented May 30, 2025 •

edited

Loading