-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(structured properties) add guide #12070
Conversation
@jjoyce0510 this is ready for initial review I still need to go through & update for consistency in naming/casing/etc, but interested for your initial feedback.. there's a lot packed into @chriscollins3456 FYI :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'm noticing... If you go to "Features" currently on the website, you'll see some inconsistency in titles.
Some titles are :
About DataHub X
and others are
X
I'd prefer to keep this consistent and simple. Users generally know if they go to Features > X they are going to learn "About DataHub X".
I just realized we did the same DataHub X thing for compliance forms docs - I should have called this consistency thing out. Can we try to simplify and make it consistent? I think it will jive better with rest of docs ecosystem..
@jjoyce0510 I replied to your inline comments about this as well, but want to surface it up -- Keeping DataHub in the H1 header is useful for SEO.. definitely agree that there's inconsistency, but the feature guides that don't have About DataHub X aren't following the template 🫠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Our users are going to be so happy to have such a simple guide. Thank you!
Checklist