Skip to content

feat(ingest): add looker meta extractor support in sql parsing #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayurinehate merged 26 commits into from
Dec 19, 2024
Merged

feat(ingest): add looker meta extractor support in sql parsing #12062

mayurinehate merged 26 commits into from
Dec 19, 2024

Conversation

@sagar-salvi-apptware
Copy link
Contributor

@sagar-salvi-apptware sagar-salvi-apptware commented Dec 9, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 9, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ing-705-looker-tool-extractor branch from 7a4550b to 6391f81 Compare December 10, 2024 05:23
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ing-705-looker-tool-extractor branch from 73ec293 to 9b3ff9a Compare December 10, 2024 14:22
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ing-705-looker-tool-extractor branch from 9b3ff9a to cb6780a Compare December 10, 2024 14:23
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ing-705-looker-tool-extractor branch from cb6780a to eaedcf2 Compare December 10, 2024 15:35
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review December 11, 2024 12:47
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 11, 2024
@hsheth2 hsheth2 requested a review from mayurinehate December 11, 2024 20:07
mayurinehate
mayurinehate requested changes Dec 12, 2024
View reviewed changes
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 12, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 13, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 17, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 18, 2024
@mayurinehate
Copy link
Collaborator

mayurinehate commented Dec 19, 2024

CI failures are unrelated

@mayurinehate mayurinehate merged commit 2e54461 into datahub-project:master Dec 19, 2024
76 of 78 checks passed
yoonhyejin pushed a commit to yoonhyejin/datahub-oss-forked that referenced this pull request Dec 23, 2024
@sagar-salvi-apptware @mayurinehate @yoonhyejin
feat(ingest): add looker meta extractor support in sql parsing (data…
bc707cb 
…hub-project#12062)

Co-authored-by: Mayuri N <[email protected]>
Co-authored-by: Mayuri Nehate <[email protected]>
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@sagar-salvi-apptware @mayurinehate @chakru-r
feat(ingest): add looker meta extractor support in sql parsing (data…
15496b0 
…hub-project#12062)

Co-authored-by: Mayuri N <[email protected]>
Co-authored-by: Mayuri Nehate <[email protected]>
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
@sagar-salvi-apptware @mayurinehate @kartikey-visa
feat(ingest): add looker meta extractor support in sql parsing (data…
b66f008 
…hub-project#12062)

Co-authored-by: Mayuri N <[email protected]>
Co-authored-by: Mayuri Nehate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees

@mayurinehate mayurinehate

Labels

ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sagar-salvi-apptware @mayurinehate