Skip to content

fix(ingest/gc): Additional dataprocess cleanup fixes #12049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
treff7es merged 4 commits into from
Dec 7, 2024
Merged

fix(ingest/gc): Additional dataprocess cleanup fixes #12049

treff7es merged 4 commits into from
Dec 7, 2024

Conversation

@treff7es
Copy link
Contributor

@treff7es treff7es commented Dec 6, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 6, 2024
hsheth2
hsheth2 approved these changes Dec 6, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/gc/dataprocess_cleanup.py
dpis.extend(runs)
start += batch_size
if len(runs) < batch_size:
if len(runs) < batch_size or start >= max_item:
Copy link
Contributor

@hsheth2 hsheth2 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should move to using scroll instead of search

Copy link
Contributor Author

@treff7es treff7es Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is no scroll endpoint for this :(

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 6, 2024
@treff7es treff7es merged commit 70bec48 into datahub-project:master Dec 7, 2024
102 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@treff7es @sleeperdeep
fix(ingest/gc): Additional dataprocess cleanup fixes (datahub-project…
0c24480 
…#12049)
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
@treff7es @kartikey-visa
fix(ingest/gc): Additional dataprocess cleanup fixes (datahub-project…
5702f28 
…#12049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hsheth2 hsheth2 hsheth2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@treff7es @hsheth2