fix(entity-service): no-op batches #12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-leifker
force-pushed
the
entity-service-batch-fix-2
branch
from
ff09983 to
4000658
Compare
datahub-cyborg
bot
added
the
needs-review
esteban
reviewed
Dec 5, 2024
metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
Refactor entityService function to filter no-op upserts. Upserts which would result in no change to the row. Still allows for updating last observed.
david-leifker
force-pushed
the
entity-service-batch-fix-2
branch
from
4000658 to
23dee1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor entityService function to filter no-op upserts. Upserts which would result in no change to the row. Still allows for updating last observed.
Another situation might occur on a transaction collision. If two identical transactions collide, one of them is re-executed and may result in a no-op as well.
Add metrics around various batch related conditions
Checklist