fix(ingest/tableau): apply page_size regardless of object count
#12026
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
…://github.com/sid-acryl/datahub-fork into cus3379-tableau-ingestion-node-limit-exceeded
hsheth2
requested changes
Dec 4, 2024
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
reviewed
Dec 6, 2024
| @@ -979,7 +979,6 @@ def get_filter_pages(query_filter: dict, page_size: int) -> List[dict]: | |||
| len(query_filter.keys()) == 1 | |||
| and query_filter.get(c.ID_WITH_IN) | |||
| and isinstance(query_filter[c.ID_WITH_IN], list) | |||
| and len(query_filter[c.ID_WITH_IN]) > 100 * page_size | |||
There was a problem hiding this comment.
do you have a sense for why this code was added in the first place? should it be outright removed, or simply tweaked
I don't like removing code unless I understand why it was added in the first place
There was a problem hiding this comment.
I am not sure, @treff7es / @mayurinehate might be aware.
There was a problem hiding this comment.
I confirm this change is safe to get in. It would have no adverse effects.
datahub-cyborg
bot
added
pending-submitter-response
hsheth2
approved these changes
Dec 11, 2024
hsheth2
changed the title
page_size regardless of object countpage_size regardless of object count
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.