Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): add user location to user profile page #12016

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(UI): add user location to user profile page #12016

wants to merge 8 commits into from
+86 −2

Conversation

samanthafigueredo5
Copy link

Checklist

This feature pulls datahub users location country and adds it to their user profile page displayed as such.
This PR involves an additional SGV globe icon and the addition of a new package for converting user country code to country.

Screenshot 2024-11-19 at 8 15 17 PM Screenshot 2024-11-19 at 8 14 52 PM
  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 3, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 3, 2024
@samanthafigueredo5 samanthafigueredo5 changed the title Sfiguere uhg add user location to profile feat(user location): add user location to user profile page Dec 9, 2024
@samanthafigueredo5 samanthafigueredo5 changed the title feat(user location): add user location to user profile page feat(UI): add user location to user profile page Dec 9, 2024
@rtekal
Copy link
Contributor

rtekal commented Dec 9, 2024 •
edited
Loading

@jjoyce0510

  1. The location (country) information is coming from ldap ingestion
  2. When the location information is not present. The UI does not show anything.

cc: @samanthafigueredo5

jjoyce0510
jjoyce0510 requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments. Overall looks promising!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 9, 2024
sfiguere added 2 commits December 11, 2024 12:05
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samanthafigueredo5 @rtekal @jjoyce0510 @Daniellundin048