Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/kafka): additional validation for oauth_db signature #11996

Merged

Conversation

mayurinehate
Copy link
Collaborator

kafka consumer silently ignores invocation of oauth callback if it does not follow expected signature. this validation ensures to raise configuration error in advance.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

kafka consumer silently ignores invocation of oauth callback if it
does not follow expected signature. this validation ensures to raise
configuration error in advance.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 2, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 2, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 2, 2024
@mayurinehate mayurinehate merged commit 8d15df0 into datahub-project:master Dec 5, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants